Skip to content

ISW-5445: RTL styles for Select arrow#1959

Merged
bigfishdesign13 merged 2 commits intodevelopmentfrom
ISW-5445/select-arrow-rtl
Mar 5, 2026
Merged

ISW-5445: RTL styles for Select arrow#1959
bigfishdesign13 merged 2 commits intodevelopmentfrom
ISW-5445/select-arrow-rtl

Conversation

@bigfishdesign13
Copy link
Copy Markdown
Collaborator

@bigfishdesign13 bigfishdesign13 commented Mar 3, 2026 •
edited
Loading

Fixes JIRA ticket ISW-5445

This PR does the following:

  • Fixes the RTL styles for the dropdown arrow in the Select component.

How has this been tested?

  • local Storybook and unit tests

NOTE: Final testing should be done in Turbine with a release candidate. In Storybook, testing was completed by manually adding dir="rtl" to the <body> tag.

Accessibility concerns or updates

  • n/a

Accessibility Checklist

  • Checked Storybook's "Accessibility" tab for color contrast and other issues.
  • The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
  • For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
  • For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
  • The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

  • I have updated the Storybook documentation and changelog accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nypl-design-system Ready Ready Preview, Comment Mar 3, 2026 8:56pm

Request Review

@bigfishdesign13 bigfishdesign13 added the Needs review Pull requests that are ready for peer review. label Mar 3, 2026
oliviawongnyc
oliviawongnyc approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@oliviawongnyc oliviawongnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Annoying about the bug? And nice work figuring it out.

FYI, I tested this by updating the design system version in the turbine repo to "@nypl/design-system-react-components": "https://github.com/NYPL/nypl-design-system.git#ISW-5445/select-arrow-rtl",, then installing and testing locally.

@bigfishdesign13 bigfishdesign13 added Ship it Pull requests that have been reviewed and approved. and removed Needs review Pull requests that are ready for peer review. labels Mar 5, 2026
@bigfishdesign13 bigfishdesign13 merged commit a90cd86 into development Mar 5, 2026
8 checks passed
@bigfishdesign13 bigfishdesign13 deleted the ISW-5445/select-arrow-rtl branch March 5, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviawongnyc oliviawongnyc oliviawongnyc approved these changes

@EdwinGuzman EdwinGuzman Awaiting requested review from EdwinGuzman

@milliesavalia milliesavalia Awaiting requested review from milliesavalia

Assignees

No one assigned

Labels

Ship it Pull requests that have been reviewed and approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bigfishdesign13 @oliviawongnyc